Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support LocalDate conversion #60

Merged
merged 10 commits into from
Jul 29, 2024
Merged

fix: support LocalDate conversion #60

merged 10 commits into from
Jul 29, 2024

Conversation

Stongtong
Copy link
Contributor

  1. compatible type is LocalDate;
  2. mybatis with duckdb 1.0.0 call getObject throw Exception, impl it

Stongtong added 3 commits July 17, 2024 15:21
@Stongtong
Update DuckDBResultSet.java
21b091d 
1. use mybatis with duckdb call getObject with column name throw exception, fix it;
2. LocalDate type not support, meet this error ,fix it
@Stongtong
Merge pull request #1 from Stongtong/Stongtong-patch-1
5ded9c2 
Update DuckDBResultSet.java
@Stongtong
Merge branch 'duckdb:main' into main
8b1d2d5
@Stongtong Stongtong mentioned this pull request Jul 17, 2024
Closed
Mause
Mause requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@Mause Mause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

src/main/java/org/duckdb/DuckDBResultSet.java Outdated Show resolved Hide resolved
@Mause Mause changed the title DuckDBResultSet bug fix fix: support LocalDate conversion Jul 29, 2024
@Mause Mause merged commit 46d8ea4 into duckdb:main Jul 29, 2024
6 of 7 checks passed
@Mause
Copy link
Member

Mause commented Jul 29, 2024

Thanks!

@Mause Mause linked an issue Jul 29, 2024 that may be closed by this pull request
duckdb with mybatis not support LocalDate type and unimplemented columnLabel`s getObject method #61
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mause Mause Mause requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duckdb with mybatis not support LocalDate type and unimplemented columnLabel`s getObject method
2 participants
@Stongtong @Mause