Schemaspy metadata #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mause
requested changes
Jun 11, 2024
| Statement statement = conn.createStatement(); | ||
| statement.closeOnCompletion(); | ||
| ResultSet rs = statement.executeQuery( | ||
| "SELECT DISTINCT function_name FROM duckdb_functions() WHERE parameter_types[1] IS NULL"); |
There was a problem hiding this comment.
This condition doesn't quite work - probably need to exclude vararg functions somehow?
There was a problem hiding this comment.
select DISTINCT function_name from duckdb_functions() where length(parameter_types) = 0??
There was a problem hiding this comment.
Probably want to look at the varargs and internal columns?
There was a problem hiding this comment.
It's not used consistently??
D select DISTINCT function_name, parameter_types, varargs from duckdb_functions() where parameter_types[1] is null;| function_name | parameter_types | varargs |
|---|---|---|
| map_from_entries | [] | ANY |
| list_median | [NULL] | |
| ... | ... | ... |
Sometimes, they have a type in the Vargas columns; other times, they have an explicit NULL as the first argument.
There was a problem hiding this comment.
@Mause is this ok solution given the above, given that vargargs aren't handled consistently?
Mause
approved these changes
Jul 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a few metadata functions so SchemaSpy mostly works. Issue #26