Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicate pushdown (updated) #78

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add predicate pushdown (updated) #78

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b96686e
add predicate pushdown
mike-luabase Oct 15, 2024
f0c99b5
add predicate pushdown
mike-luabase Oct 16, 2024
2711c8b
formatting
mike-luabase Oct 16, 2024
3eb21f1
fixed filename issue
mike-luabase Oct 16, 2024
fc52c3e
fixed filename issue
mike-luabase Oct 16, 2024
5b5929c
updated formatting
mike-luabase Oct 20, 2024
72a4af9
updated formatting
mike-luabase Oct 20, 2024
8c9e68b
added pred push tests
mike-luabase Oct 25, 2024
91e9ddf
added pred push tests2
mike-luabase Oct 25, 2024
cc3d46a
fixed formatting, removed /data
mike-luabase Oct 25, 2024
6b1440f
removed /data
mike-luabase Oct 25, 2024
d9600d4
Force remove tracked files from data/iceberg
mike-luabase Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/iceberg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ vector<IcebergManifestEntry> IcebergTable::ReadManifestEntries(const string &pat
}
} else {
auto schema = avro::compileJsonSchemaFromString(MANIFEST_ENTRY_SCHEMA);
avro::DataFileReader<c::manifest_entry> dfr(std::move(stream), schema);
c::manifest_entry manifest_entry;
avro::DataFileReader<manifest_entry> dfr(std::move(stream), schema);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are spurious and hence this file change could be removed from the PR

manifest_entry manifest_entry;
while (dfr.read(manifest_entry)) {
ret.emplace_back(IcebergManifestEntry(manifest_entry));
}
Expand Down
Loading
Loading