-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to read gzip compressed metadata files #42
Support to read gzip compressed metadata files #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @devendrasr thanks a lot for the PR! In general it looks good.
I added one comment regarding the actual unzipping and I have a more general comment: I would like to see some tests here! Maybe you can add some small test data with a test that confirms this feature works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @devendrasr Thanks for the changes, looks good! I have one more comment then I think this is good to go
@samansmink Please let me know if you are good to go. Once this is done, we can think about #43 |
looks good now, thanks again @devendrasr! |
…ed_metadata Support to read gzip compressed metadata files
The current version of iceberg extension does not support reading iceberg tables that were written with gzip compressed metadata files. Adding one more flag in the commands to consider the metadata files as gz while loading metadata.
scan data:
scan metadata:
scan snapshots:
As of now metadata_compression_codec can be none or gzip; default is none.