Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET unsafe_enable_version_guessing=true does not work with duckdb 1.1.3 #84

Closed
djouallah opened this issue Nov 27, 2024 · 5 comments · Fixed by #90
Closed

SET unsafe_enable_version_guessing=true does not work with duckdb 1.1.3 #84

djouallah opened this issue Nov 27, 2024 · 5 comments · Fixed by #90

Comments

@djouallah
Copy link

tried the new update of iceberg extension, unfortunately getting error that SET unsafe_enable_version_guessing=true; is not supported

@mullinsms
Copy link

@djouallah you beat me to opening this issue by a whole week!

@2blo
Copy link

2blo commented Dec 7, 2024

same

@naoyak
Copy link

naoyak commented Dec 17, 2024

Not sure if this is the cause, but the config option unsafe_enable_version_guessing is defined in Load() whereas in other extensions it seems to be usually defined in LoadInternal(). Maybe @teaguesterling would know from the implementation in #79?

https://github.com/duckdb/duckdb-iceberg/blob/main/src/iceberg_extension.cpp#L30-L39

@teaguesterling
Copy link
Contributor

I'm working on a fix for this (as best as I understand it). It's a bit hard to test as I think this only manifests when loading the extension when it's loaded from a different build.

@teaguesterling
Copy link
Contributor

I mucked up my dev environment but was able to get it sorted and test this out. @naoyak was right, and this was a simple change. My testing indicates this works, but I am happy to share an unsigned build if anyone else wants to test.

samansmink added a commit that referenced this issue Dec 30, 2024
Fix extension loading issue described in #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants