Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windows builds #34

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Enable windows builds #34

merged 6 commits into from
Jun 20, 2024

Conversation

samansmink
Copy link
Collaborator

This PR adds the windows builds (not yet the mingw) unfortunately. It's been a bit of a struggle though.

I've have to apply weird tricks to get this to compile, most problematic is the inlining of the fii header and adding this weird snippet to it:

// This trickery is from https://github.com/mozilla/cbindgen/issues/402#issuecomment-578680163
struct im_an_unused_struct_that_tricks_msvc_into_compilation {
    ExternResult<KernelBoolSlice> field;
    ExternResult<bool> field2;
    ExternResult<EngineBuilder*> field3;
    ExternResult<Handle<SharedExternEngine>> field4;
    ExternResult<Handle<SharedSnapshot>> field5;
    ExternResult<uintptr_t> field6;
    ExternResult<ArrowFFIData*> field7;
    ExternResult<Handle<SharedScanDataIterator>> field8;
    ExternResult<Handle<SharedScan>> field9;
    ExternResult<Handle<SharedScan>> field10;
};

The rest was actually not so bad once i figured out which windows libraries i need to link to..

@samansmink samansmink merged commit 82d2003 into duckdb:main Jun 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant