-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for access-token secrets #64
Conversation
mmaitre314
commented
Jul 14, 2024
- Implement Support for specifying token directly #20
- Add a new ACCESS_TOKEN secret provider
- Add test
- Include build instructions from the main duckdb repo in README.md
Hey @mmaitre314 thanks for the PR, looks great! To fix the CI failure, could you add the |
I added |
Ah I see, sorry I missed that Azures CI is running against DuckDB's main branch. Normally we have CI target latest stable and let duckdb/duckdb CI take care of catching changes breaking compatiblity. I've applied the patch to your branch, this should fix ci here. Then we can bump azure's version in duckdb/duckdb ci and remove the patch. |
The formatting of HTTP stats changed a bit so I updated the Regex in the test to match. Before: Now: |
thanks @mmaitre314! |
Looking into updating docs as next step, should I wait until a new version of DuckDB is released? |