fix: add evalexpr_rhai #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
reviewed
Jul 5, 2024
|
Hi @carlopi thanks for the review, I see the error on Windows too. I'll look into it tomorrow. |
This comment was marked as duplicate.
This comment was marked as duplicate.
carlopi
requested changes
Jul 8, 2024
There was a problem hiding this comment.
One thing to consider, you can consider skipping Windows CI until that gets sorted out.
See this for reference: https://github.com/duckdb/community-extensions/pull/32/files (you would need likely to skip both windows_amd64 and windows_amd64_rtools)
…nity-extensions into fix_add_evalexpr_rhai
carlopi
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.