Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension-template-rs based demo extension #184

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Add extension-template-rs based demo extension #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2dab37e
add rusty quack extension
samansmink Nov 8, 2024
1b4b277
add python to rusty_quack
samansmink Nov 8, 2024
4098c25
fix matrix generation
samansmink Nov 8, 2024
a0d0e69
checkout duckdb here
samansmink Nov 12, 2024
5212d5b
clean up
samansmink Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/_extension_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ jobs:
fetch-depth: 0
submodules: 'true'

- name: Checkout DuckDB to version
run: |
cd duckdb
git checkout ${{ inputs.duckdb_version }}
- uses: actions/checkout@v3
with:
repository: 'duckdb/duckdb'
ref: ${{ inputs.duckdb_version }}
path: duckdb
fetch-depth: 0

- id: parse-matrices
run: |
Expand Down
22 changes: 22 additions & 0 deletions extensions/rusty_quack/description.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
extension:
name: rusty_quack
description: Provides a hello world example demo from the Rust-based extension template
version: 0.0.1
language: Rust
build: cargo
license: MIT
excluded_platforms: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools"
requires_toolchains: "rust;python3"
maintainers:
- samansmink

repo:
github: duckdb/extension-template-rs
ref: 11388561c1bf27535ec81e2f8c3d3d1b590e7bd0

docs:
hello_world: |
SELECT rusty_quack('world');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?
I though it was

FROM rusty_quack('world');

given it's a table function (or it was)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I noticed I had not clicked the button to submit the review)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And no, it does not work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops mb, should've asked for a review

extended_description: |
The quack extension is based on DuckDB's [Rust Extension Template](https://github.com/duckdb/extension-template-rs/), and it's a great starting point to get started building DuckDB extensions in Rust.

Loading