Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRQL extension #14

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Add PRQL extension #14

merged 6 commits into from
Jul 2, 2024

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jun 26, 2024

The PRQL extension (see https://github.com/ywelsch/duckdb-prql) is based on an older copy of the extension template. It might need to be brought up-to-date first for this to work?

@ywelsch
Copy link
Contributor Author

ywelsch commented Jun 26, 2024

The PRQL extension needs the PRQL transpiler, which is written in Rust. The build is currently failing because the Rust toolchain is absent in this build environment.

@samansmink
Copy link
Collaborator

samansmink commented Jun 26, 2024

@ywelsch ah got ya, we will need to get that in first, i can take a stab at that. It's basically all there in the delta extension

@rustyconover
Copy link
Contributor

I have a fix in my repo for the linux_arm64 cross compile.

@carlopi
Copy link
Collaborator

carlopi commented Jul 2, 2024

@ywelsch (& also @rustyconover, given you are here and the comment is the same): I think on main I have the fix for the documentation test failing.

Could you merge or rebase on latest main? Thanks! Then extensions should pass.


Independent, we can also change this later, I think in both case it would be nice to have it explicit from the descriptor that this is a C++ + Rust extension. I think probably the simpler is having the language as C++ & Rust, would that make sense? That would allow also to enable branching on including Rust toolchain or not (see comment here: #22 (review))

@samansmink
Copy link
Collaborator

I think we can just merge this first, fix the docs thing later

@carlopi
Copy link
Collaborator

carlopi commented Jul 2, 2024

Actually, moving forward, congrats @ywelsch!

@ywelsch
Copy link
Contributor Author

ywelsch commented Jul 2, 2024

I've just pushed another update :)

@samansmink
Copy link
Collaborator

okay lets just let it run then merge both PRs

@carlopi carlopi merged commit 3c7b1d9 into duckdb:main Jul 2, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants