-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRQL extension #14
Conversation
The PRQL extension needs the PRQL transpiler, which is written in Rust. The build is currently failing because the Rust toolchain is absent in this build environment. |
@ywelsch ah got ya, we will need to get that in first, i can take a stab at that. It's basically all there in the delta extension |
I have a fix in my repo for the linux_arm64 cross compile. |
@ywelsch (& also @rustyconover, given you are here and the comment is the same): I think on main I have the fix for the documentation test failing. Could you merge or rebase on latest main? Thanks! Then extensions should pass. Independent, we can also change this later, I think in both case it would be nice to have it explicit from the descriptor that this is a C++ + Rust extension. I think probably the simpler is having the language as |
I think we can just merge this first, fix the docs thing later |
Actually, moving forward, congrats @ywelsch! |
I've just pushed another update :) |
okay lets just let it run then merge both PRs |
The PRQL extension (see https://github.com/ywelsch/duckdb-prql) is based on an older copy of the extension template. It might need to be brought up-to-date first for this to work?