Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autofix function for operator-whitespace rule #270

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added autofix function for operator-whitespace rule #270

wants to merge 8 commits into from

Conversation

ihordiachenko
Copy link

Related Issue

#94

Changes

This MR includes autofix for all operator-whitespace cases and a refactoring of the rule implementation itself.

Major changes:

  • reduced usage of regexps for performance and readability
  • reduced nesting of code and merged some redundant code branches
  • comments are treated more carefully: operators inside comments are escaped before processing
  • makes use of ES6 features

Declaration

  • I have followed the Contribution Guidelines.
  • All tests are passing.
  • ESLint doesn't produce any warnings.
  • ESLint doesn't produce any errors.
  • I'm awesome.

NOTE: It is fine if ESLint does produce warnings for your PR if there is a good reason for it.

@ihordiachenko ihordiachenko mentioned this pull request Aug 12, 2019
Open
13 tasks
@ihordiachenko
Copy link
Author

Hi, @duaraghav8 Could you review it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ihordiachenko