Magic number warning #190
Open
Magic number warning #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed |
|
@mushketyk Am I right in understanding that this rule intends to flag any numbers in the code being used without being declared as constants first? Like I'm confused because you only seem to pass on the number if its declared as a constant state variable. |
duaraghav8
force-pushed
the
develop
branch
3 times, most recently
from
8c7c5ba to
62dd518
Compare
duaraghav8
force-pushed
the
develop
branch
2 times, most recently
from
5ccb26f to
19702a3
Compare
duaraghav8
force-pushed
the
develop
branch
3 times, most recently
from
5fe12b7 to
c2464e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also implemented a couple of helper functions that should make writing unit tests for rules easier.
Implements one of the rules in #44