comma whitespace validation regexp bug fix (#162)

duaraghav8 · Feb 11, 2018 · 0972d60 · 0972d60
1 parent 6feb81a
commit 0972d60
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/rules/whitespace.js b/lib/rules/whitespace.js
@@ -55,8 +55,13 @@ module.exports = {
             let escapedEOL = jse(EOL),
                 codeAfterCurrentAssignment = sourceCode.getNextChars(node.value, 3);
 
+            // thirdCharRegexp is used in validationRegExp if EOL is unix-style, ie, len(EOL) = 1.
+            // If len(EOL) is 2, then comma + EOL cover 3 chars, then thirdCharRegexp gets treated as a checked for 4th character,
+            // resulting in false positive.
+            const thirdCharRegexp = `[^${escapedEOL}\\/]`;
             validationRegexp = new RegExp(
-                `^((,[^ ${escapedEOL}\\/].)|(, [^ ${escapedEOL}\\/])|(,${escapedEOL}[^${escapedEOL}\\/]))$`);
+                `^((,[^ ${escapedEOL}\\/].)|(, [^ ${escapedEOL}\\/])|(,${escapedEOL}${EOL.length === 1 ? thirdCharRegexp : ""}))$`
+            );
 
             (!validationRegexp.test(codeAfterCurrentAssignment)) && context.report({
                 location: {