Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2830 develop fix missing log output #2841

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

georgemccabe
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Ran a few use cases that use instance IDs and confirmed that the missing log output at the end of the run is now displayed

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run a few use cases using this branch and confirm that the log output looks good. Ideally use cases that use instances in the process list would be tested.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

It would be nice to have a test that recreates the bug scenario and ensures that the final logs are present

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 12/18/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…t are created for copying values for process list instances so they are not closed before the end of the run.
@georgemccabe georgemccabe added this to the METplus-6.1.0 milestone Dec 18, 2024
@georgemccabe georgemccabe linked an issue Dec 18, 2024 that may be closed by this pull request
24 tasks
@georgemccabe georgemccabe marked this pull request as ready for review December 18, 2024 16:07
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran on Seneca using branch main_v6.0 and saw this at the end of my log file:

DEBUG 1: Finish grid_stat by dadriaan(15368) at 2024-12-18 16:22:35Z
12/18 16:22:35.372Z metplus.ac54c6dd INFO: Finished running /d1/projects/MET/MET_releases/MET-12.0.0-beta6/bin/grid_stat - took 0:00:07.214199

I ran the same configuration/use case with bugfix_2830_main_v6.0_missing_logs and see this at the end of my log file:

DEBUG 1: Finish grid_stat by dadriaan(15368) at 2024-12-18 16:16:35Z
12/18 16:16:35.703Z metplus.71bc0505 INFO: Finished running /d1/projects/MET/MET_releases/MET-12.0.0-beta6/bin/grid_stat - took 0:00:07.414832
12/18 16:16:35.707Z metplus.71bc0505 INFO: Overwrite final conf here: /home/dadriaan/projects/NRL/task_cloud/use_case_gfs_goes/metplus_output/metplus_final.conf.20241218161109
12/18 16:16:35.707Z metplus.71bc0505 INFO: METplus took 0:05:26.707901 to run.
12/18 16:16:35.708Z metplus.71bc0505 INFO: Check the log file for more information: /home/dadriaan/projects/NRL/task_cloud/use_case_gfs_goes/metplus_output/logs/metplus.log.20241218161109
12/18 16:16:35.708Z metplus.71bc0505 INFO: METplus has successfully finished running as user dadriaan(15368).

The information I was originally expecting looks to be restored with these changes.

I also read through #2830 (comment), which is mostly over my head but seems very detailed and will be important if we need this information later.

I approve, thanks @georgemccabe!

@georgemccabe georgemccabe merged commit 235e0bf into develop Dec 18, 2024
77 checks passed
@georgemccabe georgemccabe deleted the bugfix_2830_develop_missing_logs branch December 18, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix final log output missing when instance IDs are used in process list
2 participants