-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2772 Apptainer documentation #2783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor wording changes to the documentation, which I've suggested and request that @georgemccabe reviews and accepts those that you're in agreement with.
I followed the instructions on Casper, and was successful running the model_applications/pbl/PointStat_fcstHRRR_obsAMDAR_PBLH_PyEmbed.conf
use case.
Thanks @georgemccabe, this will be a great addition!
Co-authored-by: Dan Adriaansen <[email protected]>
…, so removing the 'disabled' item to run use case in GHA
…ython embedding commands as input file arguments handles quotes
This PR also included a hotfix to change how quotation marks are added to plot_point_obs commands. Quotation marks are automatically applied for input files that are Python Embedding commands that contain spaces, so it is no longer necessary to add quotation marks in the PlotPointObs wrapper.
Pull Request Testing
Ran commands from new instructions on casper
module load apptainer
first).Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 11/13/2024.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases