Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2996 v12.0.0_beta6 #2998

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Oct 16, 2024

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the beta6 release notes at this link: MET Version 12.0.0-beta6 Release Notes (20241017)
    Pay particular attention to the items that are bolded. I used my best judgement based on the priority tags listed on the issues, but would appreciate any feedback you have to give and requests for any changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [10/17/2024].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Oct 16, 2024
@JohnHalleyGotway JohnHalleyGotway linked an issue Oct 16, 2024 that may be closed by this pull request
21 tasks
jprestop
jprestop previously approved these changes Oct 16, 2024
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnHalleyGotway I made one small suggestion as "Bugfix:" was repeated. Assuming all tests pass, I approve this request. This is a good chunk of work for beta6! Thanks for all of your effort!

@JohnHalleyGotway JohnHalleyGotway merged commit 83bf380 into develop Oct 16, 2024
3 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2996_v12.0.0-beta6 branch October 16, 2024 22:07
@JohnHalleyGotway
Copy link
Collaborator Author

Thanks for catching that typo @jprestop. It's asking for a re-review after I committed your suggestion, but I'm just going to plow ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Create the MET-12.0.0-beta6 release
2 participants