-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rust 1.80 cfg Linting and add VolumeRef impls #161
Conversation
1.65 tests are failing due to tokio requiring rust 1.70, see #159 for fix |
Zed fails, but is EOL anyway, see #160 |
@gierens hi! Shouldn't we add them to the feature list if we use them? |
Took a deeper look. I guess "volume" should be called "block-storage" now, so it's actually a bug. "identity" is reserved for the future, so maybe it's fair to exclude it in the linter, but also it may be better to just add it. |
ce3e149
to
aced2c6
Compare
aced2c6
to
61f9596
Compare
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
…atures Signed-off-by: Sandro-Alessio Gierens <[email protected]>
61f9596
to
20aa8e8
Compare
@dtantsur Yeah you're right, I should've looked into the code causing the issue ... I adjusted the PR accordingly:
|
@dtantsur Alright, CI seems to approve. So this is ready for another review. |
Thanks much! |
Rust 1.80 which is used in functional tests does more extensive cfg linting.
Because
volume
andidentity
are not known it causes functional tests to fail.This adds a linting rule to allow both those values.
For more info see: https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values