A few trivial improvements for code readability #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2023 14:05
No feature change, just make code easier to read and understand
I have spent a few time deciphering the function prototype and magic
number in code. Meaningful function declarations are essential for user
to intuitively guess and use API parameters correctly.
1) In ir_insn{} definition, opt and optx are different things.
ir_emit{,0,1,2,3} functions require optx
ir_emit_N function require opt
Make this explicit in function declaration.
2) IR_OPTX_{2,3} macros for easier optx construction in code
Naming is kinda ugly. Have not got better names.
3) Add comments to magic number used in ir_emit_N() function
4) input_count and pos should be uint16_t instead of uint32_t
Signed-off-by: Tony Su <[email protected]>
Signed-off-by: Tony Su <[email protected]>
Make it more meaningful Signed-off-by: Tony Su <[email protected]>
Signed-off-by: Tony Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No feature change, just make code easier to read and understand
I have spent a few time deciphering the function prototype and magic number in code. Meaningful function declarations are essential for user to intuitively guess and use API parameters correctly.
ir_emit{,0,1,2,3} functions require optx
ir_emit_N function require opt
Make this explicit in function declaration.
Naming is kinda ugly. Have not got better names.