Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matcher v2 #379

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Matcher v2 #379

wants to merge 35 commits into from

Conversation

ecsalomon
Copy link
Contributor

@ecsalomon ecsalomon commented Aug 13, 2018 •
edited
Loading

To do:

  • Create storage class and pass object to pipeline and components to cache interim objects
  • Collect metadata from pipeline object(s), add to matcher_log table as JSON
  • Update documentation

nanounanue and others added 30 commits May 18, 2018 11:49
@nanounanue
Bumped to version 0.2
9fa0e10
@nanounanue
Not needed anymore
a3baeff
@nanounanue
Semi-refactored. Needs @ecsalomon wisdom
bc55d7e
@nanounanue
Removing singleton ids and block_name, now is problem of the Matcher
1e337c3
@nanounanue
Blocker class added. Also discovered and killed a bug in the ValueErr…
ef79cec 
…or line
@nanounanue
Forgot self. Added
6973ced
@nanounanue
I always forget about self
6883bb0
@nanounanue
I always forget about self (again)
e920380
@nanounanue
Scorer class
8d7d1b7
@nanounanue
Using @ecsalomon suggestion regarding to the future
df00eca
@nanounanue
Removed the lines related to blocker
251d9e3
@nanounanue
Merge branch 'master' into erickas-oo
4937b59
@ecsalomon
some work
44dd54f
@ecsalomon
Merge branch 'master' of https://github.com/dssg/csh into erickas-oo
3eece57
@ecsalomon
add blocker metadata, comments
0891c69
@ecsalomon
use new blocker
1d6bda2
@ecsalomon
fix long lines
8a89248
@ecsalomon
add metadata to scorer
f2e719b
@ecsalomon
call scorer.run()
e95edb7
@ecsalomon
rename matches column to score
5c322fa
@ecsalomon
improve contraster metadata
be14a28
@ecsalomon
refactor clusterer, add metadata
3f582ac
@ecsalomon
add block key to ids
73f4876
@ecsalomon
IT RUNS!
728cce3
@ecsalomon
clean up metadata
f3b2fe9
@ecsalomon
refactor into Pipeline and Matcher, begin better metadata handling
a083607
@ecsalomon
remove metadata dictionary from cluster
4c08f87
@ecsalomon
remove metadata dict from contraster
a59f1de
@ecsalomon
remove metadata dictionary from scorer
824cf5a
@ecsalomon
rename func to describe contrasts
c9f1f91
@ecsalomon ecsalomon requested a review from nanounanue August 13, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanounanue nanounanue Awaiting requested review from nanounanue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecsalomon @nanounanue