Addition of json_source module #49
Conversation
src/alexandria3k/json_source.py
Outdated
| # pylint: disable=invalid-name | ||
|
|
||
|
|
||
| class JSONElementsCursor(ElementsCursor): |
There was a problem hiding this comment.
I can't see how this class is related to JSON. Maybe it should be in data_source.py with a name such as NestedElementsCursor? Given the class inheritance, please think hard regarding the appropriate names of all (new and existing) classes. Feel free to send me a diagram and discuss this. You can also send me a simple class diagram to discuss ideas.
Please also expand the docstring to explain what this cursor expects and what functionality it provided.
src/alexandria3k/json_source.py
Outdated
| self.elements = None | ||
|
|
||
|
|
||
| class RecordsCursor(JSONElementsCursor): |
There was a problem hiding this comment.
The comments for JSONElementsCursor also apply here, right?
|
I moved the two cursor classes to the |
Add json_source module with JSONElementsCursor and RecordsCursor Adjust docstring in json_source Move NestedElementsCursor and RecordsCursor to data_source
The
json_sourcemodule contains:JSONElementsCursor, which is identical to both howCrossrefElementsCursorandDataciteElemenrsCursorswere andRecordsCursor, which contains the methods from theWorksCursor's classes from the Crossref and the DataCite modules, with an exception of thecurrent_row_valuemethod which called for an abstract implementation