update README with instructions on sum types #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to look into specs to discover that this behavior was supported: https://github.com/dry-rb/dry-schema/blob/main/spec/integration/params/macros/value_spec.rb#L31 I feel this is a very useful pattern, and that making it more discoverable will be more user-friendly.
timhwang21
force-pushed
the
timhwang/update-readme
branch
from
9d7bd4e
to
e962d49
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to look into specs to discover that this behavior was supported:
https://github.com/dry-rb/dry-schema/blob/main/spec/integration/params/macros/value_spec.rb#L31
I feel this is a very useful pattern, and that making it more discoverable will be more user-friendly.