New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct order of parameters for Cursor's init #301

Merged

betodealmeida merged 2 commits into druid-io:master from shek1608:patch-1

Apr 29, 2024

Contributor

shek1608 commented Feb 10, 2023

Fix for issue #300

Order of parameters passed has ssl_client_cert followed by proxies
https://github.com/druid-io/pydruid/blob/master/pydruid/db/api.py#L176-L177

shek1608 added 2 commits

February 10, 2023 13:14


          Correct order of parameters for Cursor's init

ccbdde9

Fix for issue druid-io#300


          Update api.py

82980f0

Member

gianm commented Dec 1, 2023

In case someone outside pydruid code is using the Cursor constructor, how about changing the call site at https://github.com/druid-io/pydruid/blob/master/pydruid/db/api.py#L169-L177 instead of the __init__ method? Seems safer.

betodealmeida merged commit bf64cf2 into druid-io:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet