This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 617
Fix #38 #145
Open
rominf
wants to merge
1
commit into
dropbox:master
Choose a base branch
from
rominf:fix-issue-38
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix #38 #145
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -252,6 +252,18 @@ JSON11_TEST_CASE(json11_test) { | |
|
||
} | ||
|
||
JSON11_TEST_CASE(json11_test_numbers) { | ||
const std::string numbers = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to override the locale in order to really test what you intend. |
||
R"({"numbers": [0, -0, 1, 42, 0.5, -0.5, 0.5e+1, 0.5E+1, 5.0e-1, 0.5e+12]})"; | ||
const std::string expected_numbers = | ||
R"({"numbers": [0, 0, 1, 42, 0.5, -0.5, 5, 5, 0.5, 500000000000]})"; | ||
|
||
std::string err; | ||
const std::string numbers_json = Json::parse(numbers, err).dump(); | ||
std::cout << "numbers_json: " << numbers_json << std::endl; | ||
JSON11_TEST_ASSERT(numbers_json == expected_numbers); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should also test round-trip back to string to ensure no locale issues there. |
||
|
||
#if JSON11_TEST_STANDALONE_MAIN | ||
|
||
static void parse_from_stdin() { | ||
|
@@ -277,6 +289,7 @@ int main(int argc, char **argv) { | |
} | ||
|
||
json11_test(); | ||
json11_test_numbers(); | ||
} | ||
|
||
#endif // JSON11_TEST_STANDALONE_MAIN | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good approach, but I don't see it called anywhere. You probably meant to call it in parse_number().