Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Export json11Config.cmake #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fegorsch
Copy link

@fegorsch fegorsch commented May 8, 2018

Let CMake create and install json11Config.cmake allowing other CMake projects to easily import json11 as a CMake-target by setting json11_DIR to the corresponding location.

Copy link
Contributor

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like this PR contains more changes than those described in the title and description. For instance the CMAKE_DEBUG_POSTFIX seems like a library-naming change which would break compatibility, so would need some justification.

Since we don't use CMake with json11 at Dropbox, I'd be curious to hear commentary from the other community-members who have contributed to this config, such as @4brunu and @admsyn.

@4brunu
Copy link
Contributor

4brunu commented Jun 18, 2018

This PR goes behind my CMake knowledge, but I tested this change in one of my projects and it works.

So you can easily use installed builds from other CMake projects by
setting json11_DIR.
@fegorsch fegorsch force-pushed the export-json11config branch from 1b25055 to 5b82ec0 Compare June 18, 2018 13:31
@fegorsch
Copy link
Author

I removed appending CMAKE_DEBUG_POSTFIX and will eventually open another PR for this.

@fegorsch
Copy link
Author

fegorsch commented Nov 8, 2018

I'm still using json11 and I'm still using CMake. A merge of this PR or a comment on how to make it ready-to-be-merged would really help me in my day-to-day worklife :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants