Test placeholder based on complete image. #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me a long time to figure out what was going on here.
I have custom cloner and placeholder images. They are hosted on a private registry in the same image repository and differentiated by tags. For example,
These images are multiplatform images based on
drone/git
anddrone/placeholder
.Because these images differ only in tag, the check
image.Match
(which explicitly ignores tags) is detecting the cloner step as having completed with the placeholder image -- i.e., the placeholder failed(!). This is detected as a step/framework error and the stage aborts.I really have no idea why we would want to exclude tag here.