Use the pipeline's shell property in the pod

[xrl]

I want to override /bin/sh with a shell of my choice. Does this code look like a good start? How would I write a good test for this? One wrinkle, I can't get it working on my side, the pod says it can't find the /bin/bash executable, which is odd. Any tips?

[CLAassistant]

All committers have signed the CLA.

[bradrydzewski]

/bin/sh is available on all linux and posix-compliant operating systems. There is no guarantee that /bin/bash will be available. For example, the alpine image (on which many popular images are based) does not have bash:

$ docker run -t -i alpine /bin/sh
/ $ which bash
/ $ echo $?
1
/ $ which sh
/bin/sh
/ $ 

[bradrydzewski]

-dst.Entrypoint = []string{dst.Shell, "-c"}
+dst.Entrypoint = []string{"/bin/sh", "-c"}

I think this line can be reverted. There is no guarantee the user-defined shell supports -c or that the flag will have the same meaning. But more importantly, I don't think it is necessary since we pipe the script to the target shell in the line below, which is where it really counts.