-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching file/dir metadata for GSClient #275
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
========================================
- Coverage 94.8% 94.4% -0.4%
========================================
Files 20 20
Lines 1314 1347 +33
========================================
+ Hits 1246 1272 +26
- Misses 68 75 +7
|
@pjbull friendly ping :) |
Thanks @Gilthans, nice work on a first pass on this. Definitely helpful for thinking about the problem. Caching is a big enough feature/change that we'd prefer to spec it out before thinking about implementation. For example, are we confident we can implement it the same way across backends? What settings/config/env vars do we provide to end users to control behavior? Is this better implemented in the I think all of these are answerable, but worth making a plan ahead of time to make sure they don't catch us out later and increase the maintenance burden. |
Sure, that does sound reasonable. How does such a discussion happen currently? Is it done strictly by the maintainer team, or is it an open discussion in an issue? |
@Gilthans We can do this collaboratively in an issue that is opened specifically for metadata caching. Thanks! |
This is an attempt to resolve #176 .
It's a first attempt, I'd mainly like to know if this is what the maintainers had in mind. If it is, I can add some tests - which begs the question, what tests would we like to see?