Skip to content

Commit

Permalink
feat: remove deprecated websocket implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
drikqlis committed Mar 15, 2024
1 parent d089291 commit 3e71684
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 46 deletions.
2 changes: 1 addition & 1 deletion charts/vaultwarden/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sources:
- https://github.com/guerzon/vaultwarden
- https://github.com/dani-garcia/vaultwarden
appVersion: "1.30.5"
version: 0.22.20
version: 0.22.21
kubeVersion: ">=1.12.0-0"

dependencies:
Expand Down
3 changes: 0 additions & 3 deletions charts/vaultwarden/templates/_podSpec.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ containers:
- containerPort: 8080
name: http
protocol: TCP
- containerPort: {{ .Values.websocket.port }}
name: websocket
protocol: TCP
{{- if or (.Values.data) (.Values.attachments) }}
volumeMounts:
{{- with .Values.data }}
Expand Down
5 changes: 0 additions & 5 deletions charts/vaultwarden/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ data:
SMTP_ACCEPT_INVALID_HOSTNAMES: {{ .Values.smtp.acceptInvalidHostnames | quote }}
SMTP_ACCEPT_INVALID_CERTS: {{ .Values.smtp.acceptInvalidCerts | quote }}
{{- end }}
{{- if .Values.websocket.enabled }}
WEBSOCKET_ENABLED: "true"
WEBSOCKET_ADDRESS: {{ .Values.websocket.address | quote }}
WEBSOCKET_PORT: {{ .Values.websocket.port | quote }}
{{- end }}
{{- if .Values.data }}
DATA_FOLDER: {{ default "/data" .Values.data.path | quote }}
{{- end }}
Expand Down
19 changes: 0 additions & 19 deletions charts/vaultwarden/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{{- $ingress := .Values.ingress -}}
{{- $websocket := .Values.websocket -}}
{{- $fullname := .Release.fullname -}}
{{- if $ingress.enabled }}
{{- $newAPIversion := .Capabilities.APIVersions.Has "networking.k8s.io/v1" }}
Expand Down Expand Up @@ -68,15 +67,6 @@ spec:
name: {{ include "vaultwarden.fullname" $ }}
port:
name: "http"
{{- if $websocket.enabled }}
- path: {{ $ingress.pathWs }}
pathType: {{ $ingress.pathTypeWs }}
backend:
service:
name: {{ include "vaultwarden.fullname" $ }}
port:
name: "websocket"
{{- end }}
{{- end }}
- host: {{ $ingress.hostname | quote }}
http:
Expand All @@ -88,13 +78,4 @@ spec:
name: {{ include "vaultwarden.fullname" . }}
port:
name: "http"
{{- if $websocket.enabled }}
- path: {{ $ingress.pathWs }}
pathType: {{ $ingress.pathTypeWs }}
backend:
service:
name: {{ include "vaultwarden.fullname" . }}
port:
name: "websocket"
{{- end }}
{{- end }}
6 changes: 0 additions & 6 deletions charts/vaultwarden/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ spec:
port: 80
protocol: TCP
targetPort: 8080
{{- if .Values.websocket.enabled }}
- name: "websocket"
port: 3012
protocol: TCP
targetPort: {{ .Values.websocket.port }}
{{- end }}
{{- if .Values.service.ipFamilyPolicy }}
ipFamilyPolicy: {{ .Values.service.ipFamilyPolicy }}
{{- end }}
12 changes: 0 additions & 12 deletions charts/vaultwarden/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -581,15 +581,6 @@ smtp:
## @section Exposure settings
##

## @param websocket.enabled Enable websocket notifications
## @param websocket.address Websocket listen address
## @param websocket.port Websocket listen port
##
websocket:
enabled: true
address: "0.0.0.0"
port: 3012

## @param rocket.address Address to bind to
## @param rocket.port Rocket port
## @param rocket.workers Rocket number of workers
Expand Down Expand Up @@ -646,9 +637,6 @@ ingress:
## @param ingress.path Default application path for the ingress
##
path: "/"
## @param ingress.pathWs Path for the websocket ingress
##
pathWs: "/notifications/hub"
## @param ingress.pathType Path type for the ingress
## Ref: https://kubernetes.io/docs/concepts/services-networking/ingress/
##
Expand Down

0 comments on commit 3e71684

Please sign in to comment.