Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with jQuery 1.6.4, minify with yuicompressor #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

damac23
Copy link

@damac23 damac23 commented Oct 7, 2011

I've changed
if(org_title != ""){
into
if(org_title && org_title != ""){
so that TipTip works with the newest jQuery.

Probably not the best way to do it but it works for me ;)

The second change is only in the first line the marker for yuicompressor to keep the comment-header. The minified version based on yuicompressor is a little bit smaller than the version you've added to the repo.

@danimesq
Copy link

Hi, @damac23
I've forked TipTip to maintain it and use in all web projects of my community.
Please clone your pull request to: https://github.com/Software-js/TipTip
Thanks!

@danimesq
Copy link

Merge in: Floflis#7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants