Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DDF for b-parasite plant sensor #7972

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

elratt0r
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Hey @elratt0r, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • b-parasite/b-parasite.json : open source soil moisture and ambient temperature/humidity/light sensor ✔️

Validation

Tip

Everything is fine !

🕠 Updated for commit 36983bb

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thank you for your contribution 👍

We would like to ask you to create a new device support request (new issue -> device support) in this repository and to link it against your pull request. Please also make sure one device support PR only covers one device. This fosters consistency, allowing everybody to find device related information at the very same place and helps expediting searches if required. Furthermore, it enables the devs to check and verify if a DDF is created correctly or if any changes/optimizations are necessary.

Thank you very much for your support!

@elratt0r elratt0r mentioned this pull request Oct 19, 2024
1 task
@elratt0r
Copy link
Contributor Author

Fix #7983

@elratt0r elratt0r requested a review from SwoopX October 19, 2024 14:25
@SwoopX SwoopX linked an issue Oct 20, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small remarks you might want to address 👍

devices/b-parasite/b-parasite.json Outdated Show resolved Hide resolved
Comment on lines 307 to 339
"name": "config/tholddark",
"default": 12000
},
{
"name": "config/tholdoffset",
"default": 7000
},
{
"name": "state/dark",
"default": false
},
{
"name": "state/daylight",
"default": false
},
{
"name": "state/lastupdated"
},
{
"name": "state/lightlevel",
"parse": {
"at": "0x0000",
"cl": "0x0400",
"ep": 10,
"eval": "Item.val = Attr.val",
"fn": "zcl:attr"
},
"default": 0
},
{
"name": "state/lux",
"default": 0
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'd suggest to take the very same passage from one of the Philips motion sensors. Depending where you have put your DDF locally, it might be required to copy the .js script file over and amend its path to have it tested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Added conversion script 4f6c41b 51c8935

devices/b-parasite/b-parasite.json Outdated Show resolved Hide resolved
@elratt0r elratt0r requested a review from SwoopX November 13, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-parasite
3 participants