-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DDF for b-parasite plant sensor #7972
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thank you for your contribution 👍
We would like to ask you to create a new device support request (new issue -> device support) in this repository and to link it against your pull request. Please also make sure one device support PR only covers one device. This fosters consistency, allowing everybody to find device related information at the very same place and helps expediting searches if required. Furthermore, it enables the devs to check and verify if a DDF is created correctly or if any changes/optimizations are necessary.
Thank you very much for your support!
Fix #7983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small remarks you might want to address 👍
devices/b-parasite/b-parasite.json
Outdated
"name": "config/tholddark", | ||
"default": 12000 | ||
}, | ||
{ | ||
"name": "config/tholdoffset", | ||
"default": 7000 | ||
}, | ||
{ | ||
"name": "state/dark", | ||
"default": false | ||
}, | ||
{ | ||
"name": "state/daylight", | ||
"default": false | ||
}, | ||
{ | ||
"name": "state/lastupdated" | ||
}, | ||
{ | ||
"name": "state/lightlevel", | ||
"parse": { | ||
"at": "0x0000", | ||
"cl": "0x0400", | ||
"ep": 10, | ||
"eval": "Item.val = Attr.val", | ||
"fn": "zcl:attr" | ||
}, | ||
"default": 0 | ||
}, | ||
{ | ||
"name": "state/lux", | ||
"default": 0 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'd suggest to take the very same passage from one of the Philips motion sensors. Depending where you have put your DDF locally, it might be required to copy the .js script file over and amend its path to have it tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/rbaron/b-parasite