Fix/service set update #272
Open
+566
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umanggoyald11
approved these changes
Jan 19, 2025
| string service_version = 2; | ||
| string name = 1; | ||
| string version = 2; | ||
| string tags = 3; |
| tableData = append(tableData, row) | ||
|
|
||
| table := tablewriter.NewWriter(os.Stdout) | ||
| table.SetHeader([]string{"Service Name", "Service Version", "Service Action", "Service Status", "Error"}) |
There was a problem hiding this comment.
Suggested change
| table.SetHeader([]string{"Service Name", "Service Version", "Service Action", "Service Status", "Error"}) | |
| table.SetHeader([]string{"Service Name", "Version", "Action", "Status", "Error"}) |
| spinnerInstance.Stop() | ||
| var buf bytes.Buffer | ||
| table := tablewriter.NewWriter(&buf) | ||
| table.SetHeader([]string{"Service Name", "Service Version", "Service Tags", "Service Action", "Service Status", "Error"}) |
There was a problem hiding this comment.
Suggested change
| table.SetHeader([]string{"Service Name", "Service Version", "Service Tags", "Service Action", "Service Status", "Error"}) | |
| table.SetHeader([]string{"Service Name", "Version", "Tags", "Action", "Status", "Error"}) |
| @@ -63,6 +65,7 @@ func (e *Service) DeployService(ctx *context.Context, request *serviceProto.Depl | |||
| func (e *Service) DeployServiceSet(ctx *context.Context, request *serviceProto.DeployServiceSetRequest) error { | |||
| conn, requestCtx, err := grpcClient(ctx) | |||
| if err != nil { | |||
| log.Errorf("TraceID: %s", (*requestCtx).Value(constant.TraceIDKey)) | |||
There was a problem hiding this comment.
Why this is error log?
| var serviceNames []string | ||
| for _, service := range services.Services { | ||
|
|
||
| allowedInputsSlice := []string{"y", "n"} |
There was a problem hiding this comment.
Use constants for "y" or "n"
| for _, input := range allowedInputsSlice { | ||
| allowedInputs[input] = struct{}{} | ||
| } | ||
| message := "Service already deployed with different version.Do you want to deploy service " + service.Name + " ? (y/n)" |
There was a problem hiding this comment.
Use string formatter
|
resolve conflicts |
|
|
||
| services, errs := serviceClient.GetConflictingServices(&ctx, conflictingServicesRequest) | ||
| if errs != nil { | ||
| log.Fatal("Failed to list services with conflicting versions. ", errs) |
There was a problem hiding this comment.
Is the err object printed?
| val, err := inputHandler.AskWithConstraints(message, allowedInputs) | ||
|
|
||
| if err != nil { | ||
| log.Fatal(err.Error()) |
There was a problem hiding this comment.
Add some error message here
| } | ||
|
|
||
| if val != "y" { | ||
| log.Info("Skipping service ", service.Name, " from deploy") |
There was a problem hiding this comment.
Use formatted strings
| err := serviceClient.DeployServiceSet(&ctx, &deployServiceSetRequest) | ||
| if err != nil { | ||
| log.Fatal("Failed to deploy service ", err) | ||
| log.Fatal("Failed to deploy service set. ", err) |
There was a problem hiding this comment.
Is this err objected logged?
| log.Info("Skipping service ", service.Name, " from deploy") | ||
| serviceNames = append(serviceNames, service.Name) | ||
| } | ||
| // Remove services from deployServiceSetRequest |
There was a problem hiding this comment.
Should this logic be part of the client? Do you think this should be handled by the deployer?
| spinnerInstance.Prefix = fmt.Sprintf(" %s ", message) | ||
| spinnerInstance.Start() | ||
| } | ||
| } | ||
|
|
||
| log.Info(message) | ||
| fmt.Println(message) |
| client := serviceProto.NewServiceServiceClient(conn) | ||
| response, err := client.GetConflictingServices(*requestCtx, request) | ||
| if err != nil { | ||
| log.Errorf("TraceID: %s", (*requestCtx).Value(constant.TraceIDKey)) |
There was a problem hiding this comment.
Why is this an error log?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odin version(x.y.z)
Features
Resources