Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paste should clear target cell value #4268

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: paste should clear target cell value #4268

merged 2 commits into from
Dec 10, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 9, 2024

close https://github.com/dream-num/univer-pro/issues/3715
close https://github.com/dream-num/univer-pro/issues/3716
close https://github.com/dream-num/univer-pro/issues/3718
close https://github.com/dream-num/univer-pro/issues/2577

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested a review from yuhongz as a code owner December 9, 2024 12:14
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 9, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 1 second
commit  c7895ad
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.67%. Comparing base (1121c76) to head (c7895ad).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/services/clipboard/clipboard.service.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4268      +/-   ##
==========================================
+ Coverage   33.65%   33.67%   +0.01%     
==========================================
  Files        2495     2495              
  Lines      128248   128285      +37     
  Branches    28741    28755      +14     
==========================================
+ Hits        43167    43194      +27     
- Misses      85081    85091      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 10, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 10, 2024
@ybzky ybzky merged commit 3babc2f into dev Dec 10, 2024
9 checks passed
@ybzky ybzky deleted the fix-paste-clear-cell branch December 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants