Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix xlookup formula #4263

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(formula): fix xlookup formula #4263

merged 1 commit into from
Dec 12, 2024

Conversation

wpxp123456
Copy link
Contributor

close #4239

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 9, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 45 seconds
commit  f92bbcf
info  For more information, see full report

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.64%. Comparing base (a9ea9e1) to head (f92bbcf).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...gine-formula/src/functions/lookup/xlookup/index.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4263      +/-   ##
==========================================
- Coverage   33.66%   33.64%   -0.02%     
==========================================
  Files        2497     2497              
  Lines      128443   128453      +10     
  Branches    28779    28783       +4     
==========================================
- Hits        43234    43223      -11     
- Misses      85209    85230      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Dec 11, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 11, 2024
@wpxp123456 wpxp123456 merged commit ae576a7 into dev Dec 12, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the fix/formula-xlookup branch December 12, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] XLOOKUP fails if match_model has empty value
3 participants