Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new command api syncableExecuteCommand (#4045) #4210

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

okxiaoliang4
Copy link
Contributor

new command api syncableExecuteCommand

close #4045

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (2266cbd) to head (7fc903c).

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-range.ts 0.00% 4 Missing ⚠️
...kages/core/src/services/command/command.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4210      +/-   ##
==========================================
- Coverage   33.68%   33.68%   -0.01%     
==========================================
  Files        2490     2490              
  Lines      128019   128024       +5     
  Branches    28692    28695       +3     
==========================================
  Hits        43126    43126              
- Misses      84893    84898       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] setValue method to synchronize settings
2 participants