Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sheets-ui): cell-editor & formula-editor #4209

Open
wants to merge 50 commits into
base: dev
Choose a base branch
from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Dec 2, 2024

close https://github.com/dream-num/univer-pro/issues/3557
close https://github.com/dream-num/univer-pro/issues/3503
close https://github.com/dream-num/univer-pro/issues/3130
close https://github.com/dream-num/univer-pro/issues/3090
close https://github.com/dream-num/univer-pro/issues/3009
close https://github.com/dream-num/univer-pro/issues/2932
close https://github.com/dream-num/univer-pro/issues/2830
close https://github.com/dream-num/univer-pro/issues/3619
close https://github.com/dream-num/univer-pro/issues/3536

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 2, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 47 seconds
commit  3cf1c55
info  For more information, see full report

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 8.58469% with 394 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (3ce3b27) to head (3cf1c55).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../views/formula-editor/hooks/useFormulaSelection.ts 0.00% 48 Missing ⚠️
...ws/formula-editor/hooks/useSheetSelectionChange.ts 0.00% 44 Missing ⚠️
...eets-formula-ui/src/views/formula-editor/index.tsx 0.00% 44 Missing ⚠️
...views/range-selector/hooks/useLeftAndRightArrow.ts 0.00% 44 Missing ⚠️
...docs/data-model/text-x/build-utils/text-x-utils.ts 2.85% 34 Missing ⚠️
...-ui/src/views/editor-container/EditorContainer.tsx 0.00% 23 Missing ⚠️
...i/src/commands/commands/replace-content.command.ts 4.54% 21 Missing ⚠️
...src/views/range-selector/hooks/useKeyboardEvent.ts 0.00% 21 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 16 Missing ⚠️
...ages/sheets-ui/src/views/editor-container/hooks.ts 0.00% 15 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4209      +/-   ##
==========================================
- Coverage   33.67%   33.63%   -0.04%     
==========================================
  Files        2490     2493       +3     
  Lines      128045   128301     +256     
  Branches    28703    28780      +77     
==========================================
+ Hits        43114    43151      +37     
- Misses      84931    85150     +219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants