-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sheets-ui): cell-editor & formula-editor #4209
Open
weird94
wants to merge
50
commits into
dev
Choose a base branch
from
refactor/cell-editor-1125
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,006
−412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: move range should add SelectionMoveType.MOVE_END
… into refactor/cell-editor-1125
weird94
requested review from
yuhongz,
jikkai,
Jocs,
wzhudev and
VicKun4937
as code owners
December 2, 2024 14:26
View Deployment
|
Playwright test resultsDetails 20 tests across 9 suites |
wzhudev
requested changes
Dec 3, 2024
...eets/sheets-visual-comparison.spec.ts-snapshots/default-sheet-fullpage-ci-chromium-linux.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/3557
close https://github.com/dream-num/univer-pro/issues/3503
close https://github.com/dream-num/univer-pro/issues/3130
close https://github.com/dream-num/univer-pro/issues/3090
close https://github.com/dream-num/univer-pro/issues/3009
close https://github.com/dream-num/univer-pro/issues/2932
close https://github.com/dream-num/univer-pro/issues/2830
close https://github.com/dream-num/univer-pro/issues/3619
close https://github.com/dream-num/univer-pro/issues/3536
Pull Request Checklist