Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): sheet name quote #4198

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix(sheet): sheet name quote #4198

wants to merge 6 commits into from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 30, 2024

close #1898
close #1986 (No code update, just retest)
close #2186 (No code update, just retest)
close #1190

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 30, 2024

Playwright test results

failed  2 failed
passed  20 passed

Details

stats  22 tests across 9 suites
duration  7 minutes, 52 seconds
commit  c532ea7
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff set force string cell
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff set text format number cell

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 81 lines in your changes missing coverage. Please review.

Project coverage is 33.67%. Comparing base (1cce071) to head (c532ea7).

Files with missing lines Patch % Lines
.../src/controllers/numfmt-alert-render.controller.ts 0.00% 53 Missing ⚠️
...ontrollers/force-string-alert-render.controller.ts 0.00% 10 Missing ⚠️
packages/sheets-numfmt-ui/src/plugin.ts 0.00% 7 Missing ⚠️
...-formula/src/engine/analysis/lexer-tree-builder.ts 0.00% 6 Missing ⚠️
.../src/controllers/numfmt-cell-content.controller.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4198      +/-   ##
==========================================
- Coverage   33.68%   33.67%   -0.02%     
==========================================
  Files        2490     2491       +1     
  Lines      128056   128137      +81     
  Branches    28709    28724      +15     
==========================================
+ Hits        43142    43152      +10     
- Misses      84914    84985      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review December 2, 2024 03:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 2, 2024
@oumomomo
Copy link

oumomomo commented Dec 2, 2024

https://github.com/dream-num/univer-pro/issues/1898

将表1&表2的名字均加上单引号,在表3内单元格输入=引用表1&表2的区域,计算时页面会先卡死
2024_12_2 15_31_48 video.webm

@univer-bot
Copy link

univer-bot bot commented Dec 2, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/1898

Add single quotes to the names of Table 1 & Table 2, and enter = in the cell of Table 3 to reference the area of ​​Table 1 & Table 2. The page will freeze first during calculation.
2024_12_2 15_31_48 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 2, 2024
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Dec 3, 2024
@univer-bot univer-bot bot removed the qa:rejected label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants