Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add resize$ for viewport #4190

Merged
merged 2 commits into from
Dec 2, 2024
Merged

chore: add resize$ for viewport #4190

merged 2 commits into from
Dec 2, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 30, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 49 seconds
commit  e0d2779
info  For more information, see full report

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (5a13fd1) to head (e0d2779).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/viewport.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4190   +/-   ##
=======================================
  Coverage   33.68%   33.68%           
=======================================
  Files        2490     2490           
  Lines      128023   128019    -4     
  Branches    28694    28692    -2     
=======================================
  Hits        43126    43126           
+ Misses      84897    84893    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as ready for review December 2, 2024 06:11
@lumixraku lumixraku merged commit 2266cbd into dev Dec 2, 2024
9 checks passed
@lumixraku lumixraku deleted the chore/resize-viewport branch December 2, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants