Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): support repeat table header #4139

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 23, 2024

close https://github.com/dream-num/univer-pro/issues/3270

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  5dc0db1
info  For more information, see full report

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 149 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (1a9f83d) to head (5dc0db1).

Files with missing lines Patch % Lines
...e-render/src/components/docs/layout/block/table.ts 0.00% 119 Missing ⚠️
...onents/docs/layout/block/paragraph/linebreaking.ts 0.00% 9 Missing ⚠️
...s-ui/src/controllers/doc-auto-format.controller.ts 0.00% 8 Missing ⚠️
...c/commands/commands/table/doc-table-tab.command.ts 0.00% 6 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 3 Missing ⚠️
packages/docs-ui/src/basics/table.ts 0.00% 2 Missing ⚠️
...es/docs-ui/src/services/doc-auto-format.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4139      +/-   ##
==========================================
- Coverage   33.77%   33.77%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127720   127731      +11     
  Branches    28604    28610       +6     
==========================================
  Hits        43139    43139              
- Misses      84581    84592      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review November 25, 2024 13:17
@Jocs Jocs force-pushed the feat/dup-table-header branch 2 times, most recently from db7352d to 2955b90 Compare November 26, 2024 06:37
@Jocs Jocs added the qa:untested This PR is ready to be tested label Nov 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 27, 2024
@Jocs Jocs requested a review from jikkai as a code owner November 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants