Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-mention-ui): support doc mention #4093

Merged
merged 10 commits into from
Nov 19, 2024
Merged

feat(docs-mention-ui): support doc mention #4093

merged 10 commits into from
Nov 19, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 18, 2024

Break changes

  1. thread-comment-mention-data.service was removed, please use mention-io.service instead.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 18, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  4dad32b
info  For more information, see full report

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.05%. Comparing base (05a491b) to head (4dad32b).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...-mention-ui/src/views/mention-edit-popup/index.tsx 0.00% 13 Missing ⚠️
...mment-ui/src/views/thread-comment-editor/index.tsx 0.00% 6 Missing ⚠️
...s/docs-mention-ui/src/views/mention-list/index.tsx 0.00% 5 Missing ⚠️
...rc/services/mention-io/mention-io-local.service.ts 20.00% 4 Missing ⚠️
...on-ui/src/commands/commands/doc-mention.command.ts 0.00% 2 Missing ⚠️
.../src/controllers/doc-mention-trigger.controller.ts 0.00% 2 Missing ⚠️
...ntion-ui/src/services/doc-mention-popup.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4093   +/-   ##
=======================================
  Coverage   33.04%   33.05%           
=======================================
  Files        2437     2438    +1     
  Lines      126822   126826    +4     
  Branches    28395    28393    -2     
=======================================
+ Hits        41912    41920    +8     
+ Misses      84910    84906    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@weird94 weird94 merged commit 5b80481 into dev Nov 19, 2024
9 checks passed
@weird94 weird94 deleted the feat/sdk-mention branch November 19, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants