Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixed policy in rendering cells in bg extension #4048

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

lumixraku
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/3280

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 13, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  bd11940
info  For more information, see full report

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 32.92%. Comparing base (54599ce) to head (bd11940).
Report is 21 commits behind head on dev.

Files with missing lines Patch % Lines
...der/src/components/sheets/extensions/background.ts 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4048      +/-   ##
==========================================
+ Coverage   32.86%   32.92%   +0.06%     
==========================================
  Files        2501     2497       -4     
  Lines      126591   126913     +322     
  Branches    28351    28416      +65     
==========================================
+ Hits        41598    41792     +194     
- Misses      84993    85121     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Nov 14, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code duplication.

@wzhudev wzhudev merged commit 2cdea37 into dev Nov 14, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/mix-policy-bg-ext branch November 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants