Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dv): formula editor support across sheet #3956

Closed
wants to merge 1 commit into from

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Nov 5, 2024

close https://github.com/dream-num/univer-pro/issues/3050

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  91178ab
info  For more information, see full report

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.46%. Comparing base (2bea457) to head (91178ab).
Report is 164 commits behind head on dev.

Files with missing lines Patch % Lines
...ws/formula-editor/hooks/useSheetSelectionChange.ts 0.00% 2 Missing ⚠️
...eets-formula-ui/src/views/formula-editor/index.tsx 0.00% 2 Missing ⚠️
.../src/views/formula-editor/hooks/useSelectionAdd.ts 0.00% 1 Missing ⚠️
...eets-formula-ui/src/views/range-selector/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3956      +/-   ##
==========================================
- Coverage   32.46%   32.46%   -0.01%     
==========================================
  Files        2427     2427              
  Lines      126040   126046       +6     
  Branches    28193    28194       +1     
==========================================
  Hits        40915    40915              
- Misses      85125    85131       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/**
* The selection is based on the `unitId/subUnitId` of the first rendering to determine whether the selection spans subtables.
* `sheetName` is appended if there is a cross sheet
*/
isSupportAcrossSheet?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isSupportAcrossSheet?: boolean;
isSupportAcrossSheets?: boolean;

@zhaolixin7
Copy link

zhaolixin7 commented Nov 6, 2024

@Gggpound case1、添加选区时新建子表然后继续添加选区,预期替换选区 表现:添加选区
2024_11_6 11_44_57 video.webm

case2、新建定义名称》添加选区》切换子表继续添加选区》
表现:切换子表后范围中显示光标,Ctrl+A选择的是表格范围 预期:可以全选范围中的选区
2024_11_6 16_49_57 video.webm

case3,条件格式自定义公式未移除sheetname
image

case4 、数据验证/定义名称:sheet1公式引用跨表选区》再次编辑》切到选区所在的子表》拖拽引选区
表现:数据验/定义名称首次无法拖拽
2024_11_6 19_37_20 video.webm

case 5 定义名称自定义公式引用不同子表选区
表现:当前子表未显示sheetname,再次编辑时高亮位置不对
2024_11_6 19_34_26 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Nov 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Gggpound case1, when adding a selection, create a new subtable and then continue to add a selection. It is expected to replace the selection. Performance: Add a selection
2024_11_6 11_44_57 video.webm

case2, create a new definition name》Add a selection》Switch subtable to continue adding a selection》
Performance: After switching subtables, the cursor is displayed in the range, and Ctrl+A selects the table range. Expectation: All selections in the range can be selected.
2024_11_6 16_49_57 video.webm

case3, the conditional formatting custom formula did not remove sheetname
image

case4, data verification/definition name: sheet1 formula refers to cross-table selection > Edit again > Switch to the subsheet where the selection is located > Drag and drop the selection
Performance: Data validation/definition name cannot be dragged for the first time
2024_11_6 19_37_20 video.webm

Case 5 Define a name custom formula to reference different sub-table selections
Performance: The sheetname is not displayed in the current subsheet, and the highlighted position is wrong when editing again.
2024_11_6 19_34_26 video.webm
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants