-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dv): formula editor support across sheet #3956
Conversation
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3956 +/- ##
==========================================
- Coverage 32.46% 32.46% -0.01%
==========================================
Files 2427 2427
Lines 126040 126046 +6
Branches 28193 28194 +1
==========================================
Hits 40915 40915
- Misses 85125 85131 +6 ☔ View full report in Codecov by Sentry. |
/** | ||
* The selection is based on the `unitId/subUnitId` of the first rendering to determine whether the selection spans subtables. | ||
* `sheetName` is appended if there is a cross sheet | ||
*/ | ||
isSupportAcrossSheet?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isSupportAcrossSheet?: boolean; | |
isSupportAcrossSheets?: boolean; |
@Gggpound case1、添加选区时新建子表然后继续添加选区,预期替换选区 表现:添加选区 case2、新建定义名称》添加选区》切换子表继续添加选区》 case4 、数据验证/定义名称:sheet1公式引用跨表选区》再次编辑》切到选区所在的子表》拖拽引选区 case 5 定义名称自定义公式引用不同子表选区 |
@Gggpound case1, when adding a selection, create a new subtable and then continue to add a selection. It is expected to replace the selection. Performance: Add a selection case2, create a new definition name》Add a selection》Switch subtable to continue adding a selection》 case3, the conditional formatting custom formula did not remove sheetname case4, data verification/definition name: sheet1 formula refers to cross-table selection > Edit again > Switch to the subsheet where the selection is located > Drag and drop the selection Case 5 Define a name custom formula to reference different sub-table selections |
close https://github.com/dream-num/univer-pro/issues/3050
close #xxx
Pull Request Checklist