Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-ui): cache menu style #3939

Merged
merged 4 commits into from
Nov 16, 2024
Merged

fix(docs-ui): cache menu style #3939

merged 4 commits into from
Nov 16, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 2, 2024

close https://github.com/dream-num/univer-pro/issues/2536

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review November 2, 2024 12:05
@Jocs Jocs requested a review from jikkai as a code owner November 2, 2024 12:05
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 2, 2024
Copy link

github-actions bot commented Nov 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 2, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  f4f7605
info  For more information, see full report

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 51.42857% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (6ee01cd) to head (f4f7605).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...-ui/src/commands/commands/inline-format.command.ts 51.61% 30 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3939      +/-   ##
==========================================
+ Coverage   33.03%   33.04%   +0.01%     
==========================================
  Files        2437     2437              
  Lines      126798   126821      +23     
  Branches    28384    28393       +9     
==========================================
+ Hits        41885    41912      +27     
+ Misses      84913    84909       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

oumomomo commented Nov 4, 2024

在有文本样式的内容后方输入内容,工具栏对应的设置未高亮,取消样式也需要在工具栏再次点击样式使其高亮才可以取消
2024_11_4 14_28_07 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Nov 4, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

When typing content behind text style content, the corresponding settings on the toolbar are not highlighted. To cancel the style, you need to click the style again on the toolbar to highlight it.
2024_11_4 14_28_07 video.webm
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 4, 2024
@Jocs Jocs force-pushed the fix/menu-show branch 2 times, most recently from bd03e10 to 13d809d Compare November 5, 2024 09:31
@Jocs Jocs added the qa:untested This PR is ready to be tested label Nov 5, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 5, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 6, 2024
@Jocs Jocs requested a review from wzhudev as a code owner November 8, 2024 13:13
@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Nov 8, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 9, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 9, 2024
@Jocs Jocs merged commit 3be0982 into dev Nov 16, 2024
9 checks passed
@Jocs Jocs deleted the fix/menu-show branch November 16, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants