Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounds check comparing polynomials #56

Merged
merged 3 commits into from
Feb 21, 2024
Merged

bounds check comparing polynomials #56

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5924c77
bounds check when comparing polynomials
CluEleSsUK Feb 14, 2024
fedb7bc
added extra check of threshold
CluEleSsUK Feb 15, 2024
b631ca2
Fixing comment on PubPoly Equalt constant time
AnomalRoil Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions share/poly.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,11 @@ func (p *PubPoly) Equal(q *PubPoly) bool {
return false
AnomalRoil marked this conversation as resolved.
Show resolved Hide resolved
}
b := 1

if len(p.commits) < p.Threshold() || len(q.commits) < p.Threshold() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if p.Threshold() != q.Threshold() ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed they just wouldn't be equal, but I guess this might not be the case if q has strictly more commits than p

return false
}

for i := 0; i < p.Threshold(); i++ {
pb, _ := p.commits[i].MarshalBinary()
qb, _ := q.commits[i].MarshalBinary()
Expand Down
Loading