Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add benchmark tools and fixed downloading #73

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces several significant changes to the benchmark package, focusing on enhancing the file server setup, improving the dragonfly benchmark process, and incorporating a new UUID dependency. The most important changes are grouped by theme below:

File Server Setup:

  • Makefile: Added a new docker-build-file-server target to build the file server image and updated the help section accordingly.
  • Dockerfile: Created a new Dockerfile for the file server, which uses an nginx:alpine base image and generates various file sizes for benchmarking.
  • file-server.yaml: Added a new Kubernetes configuration file for the file server, defining a Service and a StatefulSet for deployment.

Dragonfly Benchmark Improvements:

  • dragonfly.go: Added a Cleanup method to the Dragonfly interface and its implementation to clean up downloaded files after benchmarks. [1] [2]
  • dragonfly.go: Improved the downloadFileByDfget and downloadFileByProxy methods to use a new getOutput method for generating output paths. [1] [2]

Logging Enhancements:

  • dragonfly.go: Added additional logging to indicate the completion of benchmarks and cleanup processes. [1] [2]

Dependency Updates:

  • go.mod: Added github.com/google/uuid as a new dependency.
  • file_server.go: Updated the file URL generation to include a UUID query parameter.

These changes collectively improve the benchmarking process by adding better logging, cleanup functionality, and a more robust file server setup.

Related Issue

Motivation and Context

@gaius-qi gaius-qi added the enhancement New feature or request label Oct 31, 2024
@gaius-qi gaius-qi self-assigned this Oct 31, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 31, 2024 04:26
Copy link
Collaborator

@Heatherchan2 Heatherchan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit cac20b3 into main Oct 31, 2024
5 checks passed
@gaius-qi gaius-qi deleted the feature/tools branch October 31, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants