Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify supports localfs filesystem backend #1637

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mhotan
Copy link
Contributor

@mhotan mhotan commented Oct 16, 2024

Relevant Issue (if applicable)

N/A

Details

Support localfs for nydusify commands. Specifically useful for convert for local filesystem-backed backend. The inspiration for this change was to test running Nydus with GCSFuse backend localfs on GKE. This is effectively a workaround as Nydus support for GCP Artifact Registry (#1594) is still a work in progress.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@mhotan mhotan requested a review from a team as a code owner October 16, 2024 12:35
@mhotan mhotan requested review from hsiangkao, power-more and Desiki-high and removed request for a team October 16, 2024 12:35
Signed-off-by: Mike Hotan <[email protected]>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (da2510b) to head (3fc325c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   60.70%   60.67%   -0.04%     
==========================================
  Files         146      146              
  Lines       48355    48355              
  Branches    46322    46322              
==========================================
- Hits        29355    29339      -16     
- Misses      17232    17247      +15     
- Partials     1768     1769       +1     
Files with missing lines Coverage Δ
contrib/nydusify/cmd/nydusify.go 13.40% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Do you need to use nydus snapshotter and make corresponding changes?

@imeoer imeoer merged commit 15ec192 into dragonflyoss:master Oct 17, 2024
24 checks passed
@mhotan
Copy link
Contributor Author

mhotan commented Oct 17, 2024

LGTM, thanks! Do you need to use nydus snapshotter and make corresponding changes?

Yes, I am using/installing Nydus snapshotter in our own GCP cluster but I am currently unaware of what corresponding changes you are referring to.

In our own fork and branch of nydus-snapshotter we been patching snapshotter.sh boot script to fix containerd config updating logic. The currently logic was not working within our GKE provisioned containerd config.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants