fix: #1423 zran check fail, because validate_header zran_count > chunk_count #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NehemiahMi
requested review from
bergwolf,
liubin and
gaius-qi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
===========================================
+ Coverage 46.29% 62.50% +16.20%
===========================================
Files 123 123
Lines 38872 43158 +4286
Branches 38872 43158 +4286
===========================================
+ Hits 17997 26974 +8977
+ Misses 19906 14874 -5032
- Partials 969 1310 +341
|
…count > chunk_count 1. targz-ref jump deduplicate chunk, because zran hasn't duplication 2. targz-ref rebuild filesystem chunk need not map Signed-off-by: 伏鸾 <[email protected]>
NehemiahMi
force-pushed
the
fix/zran_duplicated_file
branch
from
b045938
to
9d42cb1
Compare
jiangliu
approved these changes
Oct 10, 2023
Desiki-high
force-pushed
the
fix/zran_duplicated_file
branch
from
9d42cb1
to
4a252e4
Compare
|
https://github.com/dragonflyoss/nydus/actions/runs/6664717172/job/18112957206?pr=1437 |
jiangliu
reviewed
Nov 2, 2023
rafs/src/metadata/direct_v6.rs
Outdated
| @@ -1349,7 +1349,7 @@ impl RafsInodeExt for OndiskInodeWrapper { | |||
| blob_index, chunk_index | |||
| )) | |||
| }) | |||
| } else if state.is_tarfs() { | |||
| } else if state.is_tarfs() || state.meta.has_inlined_chunk_digest() { | |||
There was a problem hiding this comment.
Could you help to give more information about the context to trigger this issue?
Signed-off-by: 伏鸾 <[email protected]>
NehemiahMi
force-pushed
the
fix/zran_duplicated_file
branch
from
4a252e4
to
77f8df7
Compare
|
What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#1423
Details
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.