This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 773
feature: dfdaemon supports proxing https registries #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 21, 2019 08:25
d49fdfc
to
fe6a79a
Compare
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 67% 67.79% +0.78%
==========================================
Files 50 51 +1
Lines 2243 2304 +61
==========================================
+ Hits 1503 1562 +59
- Misses 669 671 +2
Partials 71 71
Continue to review full report at Codecov.
|
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 21, 2019 08:28
fe6a79a
to
63b7c8a
Compare
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
2 times, most recently
from
February 22, 2019 01:51
5747620
to
b112147
Compare
starnop
changed the title
feature: dfdaemon supports proxing https registries
[WIP] feature: dfdaemon supports proxing https registries
Feb 22, 2019
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 22, 2019 09:55
b112147
to
fb70824
Compare
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
3 times, most recently
from
February 22, 2019 13:11
842ae92
to
e24ddad
Compare
lowzj
changed the title
[WIP] feature: dfdaemon supports proxing https registries
feature: dfdaemon supports proxing https registries
Feb 22, 2019
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
2 times, most recently
from
February 22, 2019 13:59
6a82db0
to
54f6dc5
Compare
godliness
reviewed
Feb 25, 2019
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 25, 2019 02:30
54f6dc5
to
f15d0e9
Compare
godliness
reviewed
Feb 25, 2019
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 25, 2019 04:33
f15d0e9
to
93b8030
Compare
starnop
reviewed
Feb 25, 2019
LGTM |
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
4 times, most recently
from
February 25, 2019 11:44
fc8c0f4
to
e81174e
Compare
starnop
reviewed
Feb 25, 2019
|
||
// Properties holds all configurable properties of dfdaemon. | ||
// The default path is '/etc/dragonfly/dfdaemon.yml' | ||
type Properties struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please write a demo here and update the docs ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have add an example here.
LGTM. |
Signed-off-by: lowzj <[email protected]>
lowzj
force-pushed
the
dfdaemon-https-proxy
branch
from
February 25, 2019 12:40
e81174e
to
97a1cdc
Compare
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
feature: dfdaemon supports proxing https registries
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
feature: dfdaemon supports proxing https registries
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj [email protected]
Ⅰ. Describe what this PR did
This pull request implements a way to support registries which use
https
schema indfdaemon
's proxy pattern:dfdaemon
host ashttp_proxy
insecure-registries
dfdaemon
get the http requests, change them tohttps
schema and send https request to the real registriesⅡ. Does this pull request fix one issue?
fixes #205
related #347
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Here's a example to pull images from a https registry(
registry.cn-hangzhou.aliyuncs.com
) by using proxy pattern:/etc/dragonfly/dfdaemon.yml
, and startdfdaemon
/etc/docker/daemon.json
, and restartdocker daemon
Ⅴ. Special notes for reviews
@starnop @godliness