-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Prob sampler #129
add Prob sampler #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide UT
Until last commit, dp_pt can run with weighted sampler in dependently(also ut). Later commits will import deepmd-kit, which will rely on the version of deepmd-tensorflow |
deepmodeling/deepmd-kit#2946 merged. |
it seems nightly build version would not upload to pip, so version dependencies can not be easily assigned to requirements file. a released beta version may be needed. |
plz check deepmodeling/deepmd-kit#2932 |
it seems some ut depend on the depend version(previous version is 2.1.5 )。 @wanghan-iapcm |
deepmd_pt/utils/dataloader.py
Outdated
if prob_style == "prob_uniform": | ||
prob_v = 1.0 / float(training_data.__len__()) | ||
probs = [prob_v for ii in range(training_data.__len__())] | ||
elif prob_style == "prob_sys_size": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this case merge with else
? It should be equivalent to "prob_sys_size;0:nsys:1.0"
the case that be equivalent to "prob_sys_size;0:nsys:1.0" is actually "prob_sys_size". |
No description provided.