Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage multi workspace folder and JS refacto #8

Merged

Conversation

quentingodeau
Copy link
Contributor

Hi,
fist after all I am sorry for this pull request I change (maybe) to much things... I keep almost every things that you have previously code but move then (sorry for the complexity of review). I also change the way that you named variables to pascalCase. If it bother you, I can still change it.
So, what I have done in this:

  • Implement multi folder workspace
  • Managing of bazel sub directory ad workspace
  • Move bazel command in a specific module

@dprogm
Copy link
Owner

dprogm commented Sep 14, 2018

As long as everything continues to work I am very much in favor of having a more modularized solution that drives maintainability. Maybe we can wait until we've integrated issue #4? It may cause conflicts.

@quentingodeau
Copy link
Contributor Author

Yes I thinks that a good idea to merge the #4 before :)

@dprogm
Copy link
Owner

dprogm commented Sep 16, 2018

@quentingodeau I have merged #4 into master which indeed caused conflicts. Would be nice if you can resolve them.

I've also seen in your repo that you (re-)work a lot on the plugin. Do you have any plans with the plugin? Actually I am really glad for your work which pushes bazel integration forward ;)

@quentingodeau
Copy link
Contributor Author

Yes thanks, I will take a look and resolve the conflict :)

I'm working on the cpp part of the plugin for the moment and I'm trying to allow multi IntelliSense configuration to match targets configuration. I'm interested if you have some idea about it, for now mine is to create one configuration by configured target/os (but I not sure that is the best idea...). Then I think I will take a look to automatically create VSCode tasks cf issue #9 (if you do not solve this before).

You may have some idea/opinion about the evolution of the plugin and how you expect contributions. One way we could do this is by creating "issues" in order to propose evolution and open the discussion on it.

@quentingodeau
Copy link
Contributor Author

Hi,
It done I merged the master b518c2b, I also perform the change to use regex parse, that I mention into the #4 (547ae1f)

@dprogm dprogm merged commit 6b1062c into dprogm:master Sep 19, 2018
@quentingodeau quentingodeau deleted the feature/refactoring-and-worckspace branch September 26, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants