Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding windows compatibility #69

Merged
merged 1 commit into from Feb 15, 2018
Merged

adding windows compatibility #69

merged 1 commit into from Feb 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2018

Based on the work from #55 I created a pull request that addresses several Windows compatibility issues in the code and dpnishant's concern about regression failures in *nix platforms. It does the following things:

  1. Uses the Python platform module to determine the OS and call time.strftime appropriately. On non-windows systems it uses the old call.
  2. Changes all hardcoded "/"s in paths to use either os.sep, or os.path.join
  3. Uses the Python tempfile module to replace the hardcoded reference to "/tmp"

I tested this on Windows 10 and MacOS 10.11.6 successfully, using the following launch parameters: -a iGoat -p ios -s scripts/iOS --spawn 1

@dpnishant dpnishant merged commit d8fac93 into dpnishant:master Feb 15, 2018
@dpnishant
Copy link
Owner

@cutler-scott-ey Thanks for the PR. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant